Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.VectorBundle.Hom #4514

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Topology.VectorBundle.Hom #4514

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 31, 2023 •
edited by github-actions bot

@urkud urkud added the mathlib-port This is a port of a theory file from mathlib. label Jun 1, 2023
@urkud urkud force-pushed the port/Topology.VectorBundle.Hom branch from 3f69f41 to 686fb0e Compare June 11, 2023 22:20
@urkud urkud added the help-wanted The author needs attention to resolve issues label Jun 20, 2023
@urkud urkud added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jul 5, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jul 5, 2023
@urkud urkud force-pushed the port/Topology.VectorBundle.Hom branch from 9504b50 to 7d5634d Compare July 5, 2023 06:03
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jul 6, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 6, 2023
jcommelin
jcommelin approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts with master, but otherwise looks good.

bors d+

@bors
Copy link

bors bot commented Jul 6, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud urkud force-pushed the port/Topology.VectorBundle.Hom branch from 6ee7814 to 41077b9 Compare July 6, 2023 14:31
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jul 6, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 6, 2023
bors bot pushed a commit that referenced this pull request Jul 6, 2023
@urkud
feat: port Topology.VectorBundle.Hom (#4514)
ce6df01
@bors
Copy link

bors bot commented Jul 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.VectorBundle.Hom [Merged by Bors] - feat: port Topology.VectorBundle.Hom Jul 6, 2023
@bors bors bot closed this Jul 6, 2023
@bors bors bot deleted the port/Topology.VectorBundle.Hom branch July 6, 2023 17:06
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jul 7, 2023
@urkud @qawbecrdtey
feat: port Topology.VectorBundle.Hom (leanprover-community#4514)
228cd34
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@urkud @semorrison
feat: port Topology.VectorBundle.Hom (#4514)
84de6ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @jcommelin