Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port MeasureTheory.Measure.Lebesgue.Basic #4552

Closed
wants to merge 12 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Jun 1, 2023


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Komyyy Komyyy added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 1, 2023
@hrmacbeth
Copy link
Member

Have stopped for now.

@Komyyy Komyyy added the help-wanted The author needs attention to resolve issues label Jun 1, 2023
@Komyyy
Copy link
Collaborator Author

Komyyy commented Jun 2, 2023

https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/MeasureTheory.2EMeasure.2ELebesgue.2EBasic.20!4.234552
In Lean 4, the following tc search fails, even if we make volume reducible in MeasureSpaceDef.

variable [Fintype ι]
#synth SigmaFinite (volume : Measure (ι → ℝ))
-- fails
#synth SigmaFinite (Measure.pi fun _ => volume : Measure (ι → ℝ))
-- defeq and succeeds
#synth AddLeftInvariant (volume : Measure (ι → ℝ))
-- fails
#synth AddLeftInvariant (Measure.pi fun _ => (stdOrthonormalBasis ℝ ℝ).toBasis.addHaar : Measure (ι → ℝ))
-- defeq and succeeds

These instances are required in this file.
This file can be built by specifying latter measures now, but this should be fixed clearly.
Does anyone know how to fix this?

@Komyyy
Copy link
Collaborator Author

Komyyy commented Jun 2, 2023

At the moment, I added the porting note of this problem and continue porting.

@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jun 2, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 2, 2023
bors bot pushed a commit that referenced this pull request Jun 2, 2023
Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port MeasureTheory.Measure.Lebesgue.Basic [Merged by Bors] - feat: port MeasureTheory.Measure.Lebesgue.Basic Jun 2, 2023
@bors bors bot closed this Jun 2, 2023
@bors bors bot deleted the port/MeasureTheory.Measure.Lebesgue.Basic branch June 2, 2023 15:12
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…#4552)

Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants