Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port CategoryTheory.Bicategory.CoherenceTactic #4610

Closed
wants to merge 14 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Jun 2, 2023


So far, only the nontactic code is ported.

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 2, 2023
@joelriou joelriou added help-wanted The author needs attention to resolve issues t-meta Tactics, attributes or user commands and removed WIP Work in progress labels Jun 2, 2023
@jcommelin jcommelin requested a review from semorrison June 3, 2023 07:30
@semorrison
Copy link
Contributor

I'm working on the tactics now.

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jun 6, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 6, 2023
bors bot pushed a commit that referenced this pull request Jun 6, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jun 6, 2023

Build failed:

@jcommelin jcommelin removed the ready-to-merge This PR has been sent to bors. label Jun 6, 2023
@jcommelin
Copy link
Member

@semorrison bors wasn't happy...

bors d=semorrison

@bors
Copy link

bors bot commented Jun 6, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 7, 2023
bors bot pushed a commit that referenced this pull request Jun 7, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Bicategory.CoherenceTactic [Merged by Bors] - feat: port CategoryTheory.Bicategory.CoherenceTactic Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@bors bors bot deleted the port/CategoryTheory.Bicategory.CoherenceTactic branch June 7, 2023 03:51
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…unity#4610)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants