Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port RingTheory.Perfection #4629

Closed
wants to merge 13 commits into from

Conversation

pimotte
Copy link
Collaborator

@pimotte pimotte commented Jun 3, 2023


Open in Gitpod

Pim Otte added 3 commits June 3, 2023 16:17
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@pimotte pimotte added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 3, 2023
@xroblot
Copy link
Collaborator

xroblot commented Jun 6, 2023

@pimotte I took the liberty to push a few fixes

@int-y1 int-y1 added awaiting-review awaiting-CI and removed WIP Work in progress labels Jun 11, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 11, 2023
bors bot pushed a commit that referenced this pull request Jun 11, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented Jun 11, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.Perfection [Merged by Bors] - feat: port RingTheory.Perfection Jun 11, 2023
@bors bors bot closed this Jun 11, 2023
@bors bors bot deleted the port/RingTheory.Perfection branch June 11, 2023 14:32
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants