Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - style: recover Is of Foo which is ported from is_foo #4639

Closed
wants to merge 8 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Jun 4, 2023

I have misported is_foo to Foo because I misunderstood the rule for IsLawfulFoo.
This PR recover Is of Foo which is ported from is_foo.
This PR also renames some misported theorems.


Open in Gitpod

@Komyyy Komyyy added the WIP Work in progress label Jun 4, 2023
@Komyyy Komyyy added awaiting-review awaiting-CI and removed WIP Work in progress labels Jun 4, 2023
@RemyDegenne
Copy link
Contributor

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 4, 2023
bors bot pushed a commit that referenced this pull request Jun 4, 2023
I have misported `is_foo` to `Foo` because I misunderstood the rule for `IsLawfulFoo`.
This PR recover `Is` of `Foo` which is ported from `is_foo`.
This PR also renames some misported theorems.
@bors
Copy link

bors bot commented Jun 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title style: recover Is of Foo which is ported from is_foo [Merged by Bors] - style: recover Is of Foo which is ported from is_foo Jun 4, 2023
@bors bors bot closed this Jun 4, 2023
@bors bors bot deleted the Komyyy/NamingConvention branch June 4, 2023 05:51
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…r-community#4639)

I have misported `is_foo` to `Foo` because I misunderstood the rule for `IsLawfulFoo`.
This PR recover `Is` of `Foo` which is ported from `is_foo`.
This PR also renames some misported theorems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants