Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: add abbreviations with explicit arguments #4641

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 4, 2023

Lean 4 does not support [] fields in classes, so some definitions
like ChartedSpace.atlas have fewer explicit arguments than they used
to have in Lean 3. This PR adds abbreviations in the root namespace
with explicit arguments.


Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 4, 2023
@urkud urkud changed the title refactor: make some args explicit again refactor: add abbreviations with explicit arguments Jun 4, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 4, 2023
@urkud urkud removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 4, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 5, 2023
bors bot pushed a commit that referenced this pull request Jun 5, 2023
Lean 4 does not support `[]` fields in classes, so some definitions
like `ChartedSpace.atlas` have fewer explicit arguments than they used
to have in Lean 3. This PR adds abbreviations in the root namespace
with explicit arguments.
@bors
Copy link

bors bot commented Jun 5, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor: add abbreviations with explicit arguments [Merged by Bors] - refactor: add abbreviations with explicit arguments Jun 5, 2023
@bors bors bot closed this Jun 5, 2023
@bors bors bot deleted the YK-mfld branch June 5, 2023 01:30
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…nity#4641)

Lean 4 does not support `[]` fields in classes, so some definitions
like `ChartedSpace.atlas` have fewer explicit arguments than they used
to have in Lean 3. This PR adds abbreviations in the root namespace
with explicit arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants