Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Geometry.Manifold.Instances.Real #4654

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Geometry.Manifold.Instances.Real #4654

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 4, 2023 •
edited by github-actions bot

@urkud urkud added the mathlib-port This is a port of a theory file from mathlib. label Jun 4, 2023
@semorrison semorrison added blocked-by-math-PR This PR depends on another PR to Mathlib and removed blocked-by-math-PR This PR depends on another PR to Mathlib labels Jun 4, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 5, 2023
@urkud urkud force-pushed the port/Geometry.Manifold.Instances.Real branch from e7735b6 to 7914871 Compare June 5, 2023 05:43
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jun 5, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 5, 2023
@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 5, 2023
jcommelin
jcommelin approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 5, 2023
bors bot pushed a commit that referenced this pull request Jun 5, 2023
@urkud @Parcly-Taxel
feat: port Geometry.Manifold.Instances.Real (#4654)
92923b3 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 5, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Manifold.Instances.Real [Merged by Bors] - feat: port Geometry.Manifold.Instances.Real Jun 5, 2023
@bors bors bot closed this Jun 5, 2023
@bors bors bot deleted the port/Geometry.Manifold.Instances.Real branch June 5, 2023 14:10
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@urkud @Parcly-Taxel @qawbecrdtey
feat: port Geometry.Manifold.Instances.Real (leanprover-community#4654)
4638684 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @semorrison @jcommelin @Parcly-Taxel