Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Closed.FunctorCategory #4686

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Closed.FunctorCategory #4686

wants to merge 5 commits into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@semorrison
feat: port CategoryTheory.Closed.FunctorCategory
580d21c
@semorrison
Initial file copy from mathport
3434e29
@semorrison
automated fixes
6891e74 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@semorrison
fix
eb3157a
@semorrison semorrison added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 5, 2023
jcommelin
jcommelin approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jun 5, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 5, 2023
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 6, 2023
bors bot pushed a commit that referenced this pull request Jun 6, 2023
@semorrison
feat: port CategoryTheory.Closed.FunctorCategory (#4686)
4db78bd 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jun 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Closed.FunctorCategory [Merged by Bors] - feat: port CategoryTheory.Closed.FunctorCategory Jun 6, 2023
@bors bors bot closed this Jun 6, 2023
@bors bors bot deleted the port/CategoryTheory.Closed.FunctorCategory branch June 6, 2023 04:28
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@semorrison @qawbecrdtey
feat: port CategoryTheory.Closed.FunctorCategory (leanprover-communit…
b41e9cc 
…y#4686)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @jcommelin