Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port RepresentationTheory.Action #4700

Closed
wants to merge 9 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Jun 5, 2023


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 5, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 5, 2023
Comment on lines 1001 to 1003
μ_natural := by intros; ext; dsimp; simp
associativity := by intros; ext; dsimp; simp
left_unitality := by intros; ext; dsimp; simp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dsimps here are no longer needed.

@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Jun 6, 2023

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 6, 2023
joelriou and others added 2 commits June 6, 2023 07:51
@joelriou
Copy link
Collaborator Author

joelriou commented Jun 6, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 6, 2023
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 6, 2023

Build failed:

@jcommelin
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 6, 2023
bors bot pushed a commit that referenced this pull request Jun 6, 2023
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RepresentationTheory.Action [Merged by Bors] - feat: port RepresentationTheory.Action Jun 6, 2023
@bors bors bot closed this Jun 6, 2023
@bors bors bot deleted the port/RepresentationTheory.Action branch June 6, 2023 19:24
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants