Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port MeasureTheory.Integral.IntervalIntegral #4710

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port MeasureTheory.Integral.IntervalIntegral #4710

wants to merge 13 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 6, 2023 •
edited
Loading

Releasing lock on this branch while sleeping.

Open in Gitpod

@urkud urkud added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Jun 6, 2023
@jcommelin jcommelin added awaiting-review awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jun 6, 2023
@jcommelin jcommelin added the help-wanted The author needs attention to resolve issues label Jun 6, 2023
@jcommelin
Copy link
Member

The linter is very sad...

@urkud
Copy link
Member Author

urkud commented Jun 6, 2023

It says that intervalIntegral.integral_comp_mul_right is a bad simp lemma but it applies this lemma in intervalIntegral.smul_integral_comp_mul_right. Should I (temporarily) remove all these simp attrs?

@jcommelin
Copy link
Member

I have no idea what the best strategy is...

@urkud urkud removed the help-wanted The author needs attention to resolve issues label Jun 7, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 7, 2023
bors bot pushed a commit that referenced this pull request Jun 7, 2023
@urkud @jcommelin
feat: port MeasureTheory.Integral.IntervalIntegral (#4710)
2595548 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 7, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 7, 2023
@urkud @jcommelin
feat: port MeasureTheory.Integral.IntervalIntegral (#4710)
caa6cb6 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 7, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 7, 2023
@urkud @jcommelin
feat: port MeasureTheory.Integral.IntervalIntegral (#4710)
5e32f28 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port MeasureTheory.Integral.IntervalIntegral [Merged by Bors] - feat: port MeasureTheory.Integral.IntervalIntegral Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@bors bors bot deleted the port/MeasureTheory.Integral.IntervalIntegral branch June 7, 2023 06:36
j-loreaux pushed a commit that referenced this pull request Jun 7, 2023
@urkud @jcommelin @j-loreaux
feat: port MeasureTheory.Integral.IntervalIntegral (#4710)
8c4465d 
Co-authored-by: Johan Commelin <johan@commelin.net>
Parcly-Taxel added a commit that referenced this pull request Jun 9, 2023
@Parcly-Taxel
Drop simp tags, cf. #4710
b52b5ad
Ruben-VandeVelde pushed a commit that referenced this pull request Jun 9, 2023
@Parcly-Taxel @Ruben-VandeVelde
Drop simp tags, cf. #4710
a5e0caa
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@urkud @jcommelin @qawbecrdtey
feat: port MeasureTheory.Integral.IntervalIntegral (leanprover-commun…
37fdba3 
…ity#4710)

Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @jcommelin