Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port FieldTheory.Adjoin #4723

Closed
wants to merge 33 commits into from
Closed

[Merged by Bors] - feat: port FieldTheory.Adjoin #4723

wants to merge 33 commits into from

Conversation

riccardobrasca
Copy link
Member

Open in Gitpod

@riccardobrasca
feat: port FieldTheory.Adjoin
953cb05
@riccardobrasca
Initial file copy from mathport
5f422ed
@riccardobrasca
automated fixes
3d9d2e9 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@riccardobrasca riccardobrasca added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 6, 2023
@riccardobrasca riccardobrasca added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 6, 2023
@Ruben-VandeVelde Ruben-VandeVelde changed the title Port/FieldTheory.Adjoin feat: port FieldTheory.Adjoin Jun 6, 2023
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jun 8, 2023
Vierkantor
Vierkantor approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/FieldTheory/Adjoin.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Adjoin.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 8, 2023

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 8, 2023
riccardobrasca and others added 2 commits June 8, 2023 12:29
@riccardobrasca @Vierkantor
Update Mathlib/FieldTheory/Adjoin.lean
a1d1873 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@riccardobrasca @Vierkantor
Update Mathlib/FieldTheory/Adjoin.lean
e139bfa 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@riccardobrasca
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 8, 2023
bors bot pushed a commit that referenced this pull request Jun 8, 2023
@riccardobrasca @Ruben-VandeVelde
@adomani @ChrisHughes24
feat: port FieldTheory.Adjoin (#4723)
832c78a 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port FieldTheory.Adjoin [Merged by Bors] - feat: port FieldTheory.Adjoin Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/FieldTheory.Adjoin branch June 8, 2023 11:43
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@riccardobrasca @Ruben-VandeVelde
@adomani @ChrisHughes24 @qawbecrdtey
feat: port FieldTheory.Adjoin (leanprover-community#4723)
b9210ea 
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@riccardobrasca @Vierkantor @Ruben-VandeVelde @semorrison @adomani @ChrisHughes24