New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port RingTheory.Localization.Away.AdjoinRoot #4725
Conversation
joneugster
commented
Jun 6, 2023
•
edited
edited
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
theorem root_is_inv (r : R) : of _ r * root (C r * X - 1) = 1 := by | ||
theorem root_isInv (r : R) : of _ r * root (C r * X - 1) = 1 := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the naming here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
theorem root_is_inv (r : R) : of _ r * root (C r * X - 1) = 1 := by | ||
theorem root_isInv (r : R) : of _ r * root (C r * X - 1) = 1 := by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |