Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port MeasureTheory.Function.L2Space #4737

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port MeasureTheory.Function.L2Space #4737

wants to merge 10 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port MeasureTheory.Function.L2Space
675f1c4
@Ruben-VandeVelde
Initial file copy from mathport
c088f56
@Ruben-VandeVelde
automated fixes
b084f04 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
wip
cd18392
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 6, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 7, 2023
jcommelin
jcommelin approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jun 7, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 7, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 7, 2023
@Ruben-VandeVelde @jcommelin
feat: port MeasureTheory.Function.L2Space (#4737)
2d45c79 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port MeasureTheory.Function.L2Space [Merged by Bors] - feat: port MeasureTheory.Function.L2Space Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@bors bors bot deleted the port/MeasureTheory.Function.L2Space branch June 7, 2023 15:05
j-loreaux pushed a commit that referenced this pull request Jun 7, 2023
@Ruben-VandeVelde @jcommelin @j-loreaux
feat: port MeasureTheory.Function.L2Space (#4737)
2488c68 
Co-authored-by: Johan Commelin <johan@commelin.net>
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @jcommelin @qawbecrdtey
feat: port MeasureTheory.Function.L2Space (leanprover-community#4737)
d798f4e 
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @jcommelin @semorrison