Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port CategoryTheory.Monoidal.OfHasFiniteProducts #4826

Closed

Conversation

Vtec234
Copy link
Contributor

@Vtec234 Vtec234 commented Jun 7, 2023


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Vtec234 Vtec234 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 7, 2023
@Vtec234 Vtec234 added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 7, 2023
@semorrison semorrison changed the title Port/category theory.monoidal.of has finite products feat: port CategoryTheory.Monoidal.OfHasFiniteProducts Jun 8, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Jun 8, 2023

✌️ Vtec234 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 8, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 8, 2023
Vtec234 and others added 3 commits June 8, 2023 08:58
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: Scott Morrison <scott@tqft.net>
@Vtec234
Copy link
Contributor Author

Vtec234 commented Jun 8, 2023

bors r+

@bors
Copy link

bors bot commented Jun 8, 2023

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 8, 2023
@Vtec234
Copy link
Contributor Author

Vtec234 commented Jun 8, 2023

bors r+

@bors
Copy link

bors bot commented Jun 8, 2023

👎 Rejected by label

@Vtec234 Vtec234 removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 8, 2023
@Vtec234
Copy link
Contributor Author

Vtec234 commented Jun 8, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 8, 2023
Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com>
@bors
Copy link

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Monoidal.OfHasFiniteProducts [Merged by Bors] - feat: port CategoryTheory.Monoidal.OfHasFiniteProducts Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/CategoryTheory.Monoidal.OfHasFiniteProducts branch June 8, 2023 16:12
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…mmunity#4826)

Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants