Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.DedekindDomain.Dvr #4846

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.DedekindDomain.Dvr #4846

wants to merge 7 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jun 8, 2023

Open in Gitpod

mo271 added 4 commits June 8, 2023 09:18
@mo271
feat: port RingTheory.DedekindDomain.Dvr
236f442
@mo271
Initial file copy from mathport
a677fbf
@mo271
automated fixes
8c5fd37 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
first pass
136f2c5
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 8, 2023
@mo271 mo271 added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels Jun 8, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 8, 2023
bors bot pushed a commit that referenced this pull request Jun 8, 2023
@mo271
feat: port RingTheory.DedekindDomain.Dvr (#4846)
d950df7 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.DedekindDomain.Dvr [Merged by Bors] - feat: port RingTheory.DedekindDomain.Dvr Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/RingTheory.DedekindDomain.Dvr branch June 8, 2023 09:01
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@mo271 @qawbecrdtey
feat: port RingTheory.DedekindDomain.Dvr (leanprover-community#4846)
659848d 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mo271 @semorrison