New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port Topology.ContinuousFunction.Ideals #4852
Conversation
mo271
commented
Jun 8, 2023
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
There was something wrong with the names It should have been an upper case "c" in CharacterSpace or one would have to change the name space
|
@mo271 I wasn't exactly sure about this either, but my feeling is to keep the namespace uppercase (at the very least to be consistent with the previous file, or else change the namespace in that file too). It's possible we'll refactor Oh, and for clarity: dot notation won't work even if you make this lowercase because all Lean sees for the type is the I have addressed a lot of naming issues in this file (sorry, there were a bunch of tricky ones in there!) |
Regarding the strange time-outs in the linter: Let's try nolint and adidng a porting note |
bors merge |
Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>