Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Algebra.Category.Semigroup.Basic #4857

Closed
wants to merge 18 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jun 8, 2023


TODO: Rename the folder to SemigroupCat, but I want to do this at the end so it does not mess up the git history too much.

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joneugster joneugster added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 8, 2023
@joneugster joneugster added the help-wanted The author needs attention to resolve issues label Jun 8, 2023
@joneugster joneugster removed the WIP Work in progress label Jun 9, 2023
@semorrison
Copy link
Contributor

I just merged master as #5545 and #5546 are intended to help here.

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jun 30, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 1, 2023
@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Jul 1, 2023
bors bot pushed a commit that referenced this pull request Jul 1, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jul 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.Category.Semigroup.Basic [Merged by Bors] - feat: port Algebra.Category.Semigroup.Basic Jul 1, 2023
@bors bors bot closed this Jul 1, 2023
@bors bors bot deleted the port/Algebra.Category.Semigroup.Basic branch July 1, 2023 05:38
semorrison added a commit that referenced this pull request Jul 1, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
semorrison added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants