Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.SpecialFunctions.Integrals #4860

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Analysis.SpecialFunctions.Integrals #4860

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 8, 2023

Open in Gitpod

urkud added 4 commits June 8, 2023 08:20
@urkud
feat: port Analysis.SpecialFunctions.Integrals
fe6711c
@urkud
Initial file copy from mathport
5f8f0fd
@urkud
automated fixes
442262a 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Simple fixes
3a647c0
@Parcly-Taxel
Copy link
Collaborator

I've got the whole file sorted out; I'm going to push.

@urkud
Copy link
Member Author

urkud commented Jun 8, 2023

@Parcly-Taxel Next time please ask for permission of the PR author before starting to work. This way you avoid duplication of effort. We have plenty of files on the queue and PRs with help-wanted label.

@urkud
Copy link
Member Author

urkud commented Jun 8, 2023

@Parcly-Taxel You were going to push 2h ago. Did you forget?

@urkud urkud added the mathlib-port This is a port of a theory file from mathlib. label Jun 8, 2023
@urkud
Copy link
Member Author

urkud commented Jun 8, 2023

@Parcly-Taxel Sorry for miscommunication on my side.

@urkud urkud added the awaiting-review The author would like community review of the PR label Jun 8, 2023
@urkud
Copy link
Member Author

urkud commented Jun 8, 2023

I assume that @Parcly-Taxel took over this PR, so I can review it. Thanks!
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 8, 2023
bors bot pushed a commit that referenced this pull request Jun 8, 2023
@urkud @Parcly-Taxel
feat: port Analysis.SpecialFunctions.Integrals (#4860)
840194b 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.SpecialFunctions.Integrals [Merged by Bors] - feat: port Analysis.SpecialFunctions.Integrals Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/Analysis.SpecialFunctions.Integrals branch June 8, 2023 19:28
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@urkud @Parcly-Taxel @qawbecrdtey
feat: port Analysis.SpecialFunctions.Integrals (leanprover-community#…
286d11c 
…4860)

Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @Parcly-Taxel