[Merged by Bors] - feat: Port Logic.Nonempty #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[] depends on: #484 - Deleted `nonempty_empty` since `std4` now has that as `not_nonempty_empty` and as a simp lemma - Added an import to access `Zero` for `Zero.Nonempty` - Could not provide a `One.Nonempty` because `One` isn't defined yet - Used mathport's implicit type params, not sure what the style guidelines are - Gave previously anonymous instances names: `Prod.Nonempty`, `Pi.Nonempty`
semorrison
added
the
blocked-by-other-PR
pechersky
added
awaiting-review
semorrison
reviewed
Oct 25, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
- [x] depends on: #484 * Deleted `nonempty_empty` since `std4` now has that as `not_nonempty_empty` and as a simp lemma * Added an import to access `Zero` for `Zero.Nonempty` * Could not provide a `One.Nonempty` because `One` isn't defined yet * Used mathport's implicit type params, not sure what the style guidelines are * Gave previously anonymous instances names: `Prod.Nonempty`, `Pi.Nonempty` Co-authored-by: Jakob von Raumer <jakob@von-raumer.de> Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonempty_emptysincestd4now has that asnot_nonempty_emptyand as a simp lemmaZeroforZero.NonemptyOne.NonemptybecauseOneisn't defined yetProd.Nonempty,Pi.Nonempty