Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port FieldTheory.IsAlgClosed.Basic #4888

Closed
wants to merge 17 commits into from
Closed

[Merged by Bors] - feat: port FieldTheory.IsAlgClosed.Basic #4888

wants to merge 17 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin
feat: port FieldTheory.IsAlgClosed.Basic
2d1b873
@jcommelin
Initial file copy from mathport
bd93a94
@jcommelin
automated fixes
39f3cfa 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jcommelin jcommelin added the mathlib-port This is a port of a theory file from mathlib. label Jun 9, 2023
@jcommelin jcommelin added the help-wanted The author needs attention to resolve issues label Jun 9, 2023
@Vierkantor
Copy link
Contributor

I have an hour or two to try to get this done.

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jun 9, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 9, 2023
bors bot pushed a commit that referenced this pull request Jun 9, 2023
@jcommelin @mo271
@ChrisHughes24 @Vierkantor @Ruben-VandeVelde
feat: port FieldTheory.IsAlgClosed.Basic (#4888)
ef9a563 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 9, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port FieldTheory.IsAlgClosed.Basic [Merged by Bors] - feat: port FieldTheory.IsAlgClosed.Basic Jun 9, 2023
@bors bors bot closed this Jun 9, 2023
@bors bors bot deleted the port/FieldTheory.IsAlgClosed.Basic branch June 9, 2023 23:23
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@jcommelin @mo271
@ChrisHughes24 @Vierkantor @Ruben-VandeVelde @qawbecrdtey
feat: port FieldTheory.IsAlgClosed.Basic (leanprover-community#4888)
9e044de 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Vierkantor <vierkantor@vierkantor.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jcommelin @Vierkantor @semorrison @Ruben-VandeVelde @mo271 @ChrisHughes24