Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port MeasureTheory.Function.ConditionalExpectation.Basic #4898

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port MeasureTheory.Function.ConditionalExpectation.Basic #4898

wants to merge 4 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added mathlib-port This is a port of a theory file from mathlib. WIP Work in progress help-wanted The author needs attention to resolve issues and removed mathlib-port This is a port of a theory file from mathlib. WIP Work in progress help-wanted The author needs attention to resolve issues labels Jun 9, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

This file has been split in mathlib3; first new PR is #5005.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 13, 2023
@Parcly-Taxel
Copy link
Collaborator

I'm going to force-push to this branch with the reduced, fully fixed file.

@Parcly-Taxel
feat: port MeasureTheory.Function.ConditionalExpectation.Basic
fc9e71d
@Parcly-Taxel
Initial file copy from mathport
d9905c5
@Parcly-Taxel
automated fixes
97c960b 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
761d89d
@Parcly-Taxel Parcly-Taxel force-pushed the port/MeasureTheory.Function.ConditionalExpectation.Basic branch from fdeaf93 to 761d89d Compare June 17, 2023 12:07
jcommelin
jcommelin approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@bors
Copy link

bors bot commented Jun 17, 2023

👎 Rejected by label

@semorrison semorrison added the ready-to-merge This PR has been sent to bors. label Jun 17, 2023
@Parcly-Taxel Parcly-Taxel removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 17, 2023
@RemyDegenne
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Jun 17, 2023
@Parcly-Taxel
feat: port MeasureTheory.Function.ConditionalExpectation.Basic (#4898)
529b276
@bors
Copy link

bors bot commented Jun 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port MeasureTheory.Function.ConditionalExpectation.Basic [Merged by Bors] - feat: port MeasureTheory.Function.ConditionalExpectation.Basic Jun 17, 2023
@bors bors bot closed this Jun 17, 2023
@bors bors bot deleted the port/MeasureTheory.Function.ConditionalExpectation.Basic branch June 17, 2023 12:39
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@Parcly-Taxel @alexkeizer
feat: port MeasureTheory.Function.ConditionalExpectation.Basic (#4898)
37124d6
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@Parcly-Taxel @semorrison
feat: port MeasureTheory.Function.ConditionalExpectation.Basic (#4898)
41687c9
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@Parcly-Taxel @semorrison
feat: port MeasureTheory.Function.ConditionalExpectation.Basic (#4898)
f505e25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @Parcly-Taxel @RemyDegenne @jcommelin @semorrison