Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor: Defs and Lemmas files for Bitvec #4899

Closed
wants to merge 6 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented Jun 9, 2023

The Core file was just dumped from Lean3 core. I've split it into Defs and Lemmas in the style of the List folder for example.


Open in Gitpod

@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label Jun 9, 2023
@Ruben-VandeVelde Ruben-VandeVelde changed the title refactor(Data/Bitvec): Defs and Lemmas file refactor: Defs and Lemmas files for Bitvec Jun 9, 2023
@tobiasgrosser
Copy link
Collaborator

This will certainly help our proof efforts. @digama0, you OKed our last commit in this area. Maybe you or sb else could have a look again?

@digama0
Copy link
Member

digama0 commented Jun 10, 2023

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 10, 2023
bors bot pushed a commit that referenced this pull request Jun 10, 2023
The `Core` file was just dumped from Lean3 core. I've split it into `Defs` and `Lemmas` in the style of the `List` folder for example.
@bors
Copy link

bors bot commented Jun 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor: Defs and Lemmas files for Bitvec [Merged by Bors] - refactor: Defs and Lemmas files for Bitvec Jun 10, 2023
@bors bors bot closed this Jun 10, 2023
@bors bors bot deleted the rearrange-bitvec branch June 10, 2023 11:00
@tobiasgrosser
Copy link
Collaborator

tobiasgrosser commented Jun 10, 2023

Thank you, @digama0 and @Parcly-Taxel.

qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
The `Core` file was just dumped from Lean3 core. I've split it into `Defs` and `Lemmas` in the style of the `List` folder for example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants