Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: align init.{core, logic} #490

Closed
wants to merge 4 commits into from
Closed

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Oct 22, 2022

With this, the files init.core and init.logic are synchronized, although we aren't currently tracking files from init in port-status.

@semorrison
Copy link
Contributor

bors merge

bors bot pushed a commit that referenced this pull request Oct 23, 2022
With this, the files `init.core` and `init.logic` are synchronized, although we aren't currently tracking files from `init` in [port-status](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
@bors
Copy link

bors bot commented Oct 23, 2022

Build failed:

  • Build

@semorrison
Copy link
Contributor

This did not compile with master. I merged, and fixed the imports in Simps.

In Init.Logic, the new @[trans] attribute PR'd in #253 incorrectly rejected the @[trans] attribute on

@[deprecated, trans] theorem Implies.trans {p q r : Prop} (h₁ : p → q) (h₂ : q → r) :
    p → r := fun hp => h₂ (h₁ hp)

I left a note and removed the attribute for now.

@digama0
Copy link
Member Author

digama0 commented Oct 24, 2022

The original lean 3 would have rejected it too - I rewrote the theorem to use -> instead of Implies, but I guess that's not an option in this case. trans will probably need special support to handle ->.

@digama0
Copy link
Member Author

digama0 commented Oct 24, 2022

bors merge

bors bot pushed a commit that referenced this pull request Oct 24, 2022
With this, the files `init.core` and `init.logic` are synchronized, although we aren't currently tracking files from `init` in [port-status](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: align init.{core, logic} [Merged by Bors] - feat: align init.{core, logic} Oct 24, 2022
@bors bors bot closed this Oct 24, 2022
@bors bors bot deleted the init_logic branch October 24, 2022 02:07
bors bot pushed a commit that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants