Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Lie.Engel #4926

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Lie.Engel #4926

wants to merge 12 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port Algebra.Lie.Engel
b385dcc
@Ruben-VandeVelde
Initial file copy from mathport
a963058
@Ruben-VandeVelde
automated fixes
fb0bfdf 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
1
79a5b27
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 9, 2023
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 9, 2023
@Ruben-VandeVelde Ruben-VandeVelde removed the help-wanted The author needs attention to resolve issues label Jun 11, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR awaiting-CI labels Jun 11, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Jun 12, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 12, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde
feat: port Algebra.Lie.Engel (#4926)
df71da7 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 12, 2023

Build failed:

@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde
feat: port Algebra.Lie.Engel (#4926)
eba2601 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.Lie.Engel [Merged by Bors] - feat: port Algebra.Lie.Engel Jun 12, 2023
@bors bors bot closed this Jun 12, 2023
@bors bors bot deleted the port/Algebra.Lie.Engel branch June 12, 2023 10:19
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@Ruben-VandeVelde @semorrison
feat: port Algebra.Lie.Engel (#4926)
0cb5b5f 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ruben-VandeVelde @semorrison