Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port FieldTheory.IsAlgClosed.Spectrum #4935

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port FieldTheory.IsAlgClosed.Spectrum #4935

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 10, 2023

Open in Gitpod

urkud added 5 commits June 9, 2023 19:39
@urkud
feat: port FieldTheory.IsAlgClosed.Spectrum
cf3da84
@urkud
Initial file copy from mathport
d1534c2
@urkud
automated fixes
be59aa8 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Fix compile
4c89e0d
@urkud
auto: naming
d471c72
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Jun 10, 2023
jcommelin
jcommelin approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 10, 2023
bors bot pushed a commit that referenced this pull request Jun 10, 2023
@urkud
feat: port FieldTheory.IsAlgClosed.Spectrum (#4935)
4799639
@bors
Copy link

bors bot commented Jun 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port FieldTheory.IsAlgClosed.Spectrum [Merged by Bors] - feat: port FieldTheory.IsAlgClosed.Spectrum Jun 10, 2023
@bors bors bot closed this Jun 10, 2023
@bors bors bot deleted the port/FieldTheory.IsAlgClosed.Spectrum branch June 10, 2023 04:28
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@urkud @qawbecrdtey
feat: port FieldTheory.IsAlgClosed.Spectrum (leanprover-community#4935)
128d32c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @semorrison