Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.Convex.Intrinsic #4937

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Analysis.Convex.Intrinsic #4937

wants to merge 7 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Jun 10, 2023 •
edited

todo:

  • intrinsicClosure_mono proof is broken

Open in Gitpod

@int-y1
feat: port Analysis.Convex.Intrinsic
59b5547
@int-y1
Initial file copy from mathport
77f2a4b
@int-y1
automated fixes
edd8230 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix
3c85aa1
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 10, 2023
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 10, 2023
@int-y1 int-y1 added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jun 13, 2023
jcommelin
jcommelin approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 13, 2023
bors bot pushed a commit that referenced this pull request Jun 13, 2023
@int-y1
feat: port Analysis.Convex.Intrinsic (#4937)
d9d8c53
@bors
Copy link

bors bot commented Jun 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.Convex.Intrinsic [Merged by Bors] - feat: port Analysis.Convex.Intrinsic Jun 13, 2023
@bors bors bot closed this Jun 13, 2023
@bors bors bot deleted the port/Analysis.Convex.Intrinsic branch June 13, 2023 07:01
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@int-y1 @alexkeizer
feat: port Analysis.Convex.Intrinsic (#4937)
6f52399
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@int-y1 @semorrison
feat: port Analysis.Convex.Intrinsic (#4937)
519b1a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@int-y1 @jcommelin @semorrison