[Merged by Bors] - chore: cleanup some simp-related porting notes #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
1 task
|
Thanks! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
I was looking on #4933 to see what simp related porting notes I could improve after leanprover/lean4#2266 lands in Lean 4. Mostly things I found could be cleaned up in any case, and so I've moved those into this PR. There is lots more work to do diagnosing all the simp-related porting notes! Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Jun 11, 2023
The bumps to nightly-2023-06-10, which includes @gebner's leanprover/lean4#2266. After this is merged I encourage everyone to look around at simp regressions! - [x] depends on: #4954 (I've moved changes that work without lean4#2266 to this PR) [](https://gitpod.io/from-referrer/) Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
](https://gitpod.io/from-referrer/){kind=link}
…4954) I was looking on leanprover-community#4933 to see what simp related porting notes I could improve after leanprover/lean4#2266 lands in Lean 4. Mostly things I found could be cleaned up in any case, and so I've moved those into this PR. There is lots more work to do diagnosing all the simp-related porting notes! Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
The bumps to nightly-2023-06-10, which includes @gebner's leanprover/lean4#2266. After this is merged I encourage everyone to look around at simp regressions! - [x] depends on: leanprover-community#4954 (I've moved changes that work without lean4#2266 to this PR) [](https://gitpod.io/from-referrer/) Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking on #4933 to see what simp related porting notes I could improve after leanprover/lean4#2266 lands in Lean 4. Mostly things I found could be cleaned up in any case, and so I've moved those into this PR.
There is lots more work to do diagnosing all the simp-related porting notes!