Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Geometry.Euclidean.Angle.Oriented.Basic #4966

Closed

Conversation

Parcly-Taxel
Copy link
Collaborator

@Parcly-Taxel Parcly-Taxel commented Jun 11, 2023

@Parcly-Taxel Parcly-Taxel added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 11, 2023
@semorrison
Copy link
Contributor

bors d+

But please wait until #4602 has been reviewed and merged; this delegation is just about the Oriented.Basic file.

@bors
Copy link

bors bot commented Jun 12, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 12, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 13, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 13, 2023
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

@bors
Copy link

bors bot commented Jun 13, 2023

👎 Rejected by label

@Parcly-Taxel Parcly-Taxel removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 13, 2023
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 13, 2023
@bors
Copy link

bors bot commented Jun 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Euclidean.Angle.Oriented.Basic [Merged by Bors] - feat: port Geometry.Euclidean.Angle.Oriented.Basic Jun 13, 2023
@bors bors bot closed this Jun 13, 2023
@bors bors bot deleted the port/Geometry.Euclidean.Angle.Oriented.Basic branch June 13, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants