Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: correct for surprising precedence in Bool DeMorgan laws #4987

Closed
wants to merge 1 commit into from

Conversation

alexkeizer
Copy link
Collaborator

@alexkeizer alexkeizer commented Jun 12, 2023

The DeMorgan laws as stated were being parsed as an inequality

! ((a && b) = (!a || !b))

So, I added parenthesis to force the intended meaning of

(!(a && b)) = (!a || !b)

Open in Gitpod

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 12, 2023
@eric-wieser eric-wieser changed the title Fix Bool DeMorgan laws fix: Bool DeMorgan laws Jun 12, 2023
@eric-wieser eric-wieser changed the title fix: Bool DeMorgan laws fix: correct for surprising precedence in Bool DeMorgan laws Jun 12, 2023
bors bot pushed a commit that referenced this pull request Jun 12, 2023
The DeMorgan laws as stated were being parsed as an inequality
```lean
! ((a && b) = (!a || !b))
```
So, I added parenthesis to force the intended meaning of 
```lean
(!(a && b)) = (!a || !b)
```
@bors
Copy link

bors bot commented Jun 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: correct for surprising precedence in Bool DeMorgan laws [Merged by Bors] - fix: correct for surprising precedence in Bool DeMorgan laws Jun 12, 2023
@bors bors bot closed this Jun 12, 2023
@bors bors bot deleted the fix-bool-de-morgan branch June 12, 2023 12:16
semorrison pushed a commit that referenced this pull request Jun 25, 2023
The DeMorgan laws as stated were being parsed as an inequality
```lean
! ((a && b) = (!a || !b))
```
So, I added parenthesis to force the intended meaning of 
```lean
(!(a && b)) = (!a || !b)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants