Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port CategoryTheory.Monoidal.CommMon_ #5012

Closed
wants to merge 6 commits into from

Conversation

joelriou
Copy link
Collaborator


Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 13, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 13, 2023
@semorrison
Copy link
Contributor

I pushed some minor improvements to automation. Please merge if they look okay, or ping me again.

bors d+

@bors
Copy link

bors bot commented Jun 14, 2023

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 14, 2023
@semorrison
Copy link
Contributor

We could also add := by aesop_cat defaults to the three arguments of MonoidalNatIso.ofComponents, but I'm happy to do that later.

Co-authored-by: Scott Morrison <scott@tqft.net>
@joelriou
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 14, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 14, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Monoidal.CommMon_ [Merged by Bors] - feat: port CategoryTheory.Monoidal.CommMon_ Jun 14, 2023
@bors bors bot closed this Jun 14, 2023
@bors bors bot deleted the port/CategoryTheory.Monoidal.CommMon_ branch June 14, 2023 08:08
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants