Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: clean up porting notes about op_induction #5035

Closed
wants to merge 1 commit into from

Conversation

semorrison
Copy link
Contributor

Closes #4551.

Essentially op_induction is not necessary, now that Opposite.rec' is labelled with @[eliminator]. It would be nice if we could use this from inside aesop, see leanprover-community/aesop#59.


Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI labels Jun 14, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 14, 2023
bors bot pushed a commit that referenced this pull request Jun 14, 2023
Closes #4551.

Essentially `op_induction` is not necessary, now that `Opposite.rec'` is labelled with `@[eliminator]`. It would be nice if we could use this from inside `aesop`, see leanprover-community/aesop#59.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 14, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: clean up porting notes about op_induction [Merged by Bors] - chore: clean up porting notes about op_induction Jun 14, 2023
@bors bors bot closed this Jun 14, 2023
@bors bors bot deleted the op_induction_cleanup branch June 14, 2023 07:38
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
Closes #4551.

Essentially `op_induction` is not necessary, now that `Opposite.rec'` is labelled with `@[eliminator]`. It would be nice if we could use this from inside `aesop`, see leanprover-community/aesop#59.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
semorrison added a commit that referenced this pull request Jun 25, 2023
Closes #4551.

Essentially `op_induction` is not necessary, now that `Opposite.rec'` is labelled with `@[eliminator]`. It would be nice if we could use this from inside `aesop`, see leanprover-community/aesop#59.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port op_induction
2 participants