Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Geometry.Euclidean.MongePoint #5056

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - feat: port Geometry.Euclidean.MongePoint #5056

wants to merge 20 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 14, 2023
@int-y1
Copy link
Collaborator

int-y1 commented Jun 24, 2023

@Ruben-VandeVelde is this ready?

@int-y1 int-y1 removed the help-wanted The author needs attention to resolve issues label Jun 24, 2023
jcommelin
jcommelin approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like decide! got a bit less smart. We should look into this at some point.
But for now, I don't see a reason not to merge this.

bors d+

@bors
Copy link

bors bot commented Jun 28, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 28, 2023
@Ruben-VandeVelde @mo271 @int-y1
feat: port Geometry.Euclidean.MongePoint (#5056)
9abfb25 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented Jun 28, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 28, 2023
@Ruben-VandeVelde @mo271 @int-y1
feat: port Geometry.Euclidean.MongePoint (#5056)
902aa53 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented Jun 28, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 28, 2023
@Ruben-VandeVelde @mo271 @int-y1
feat: port Geometry.Euclidean.MongePoint (#5056)
ef7e7c0 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented Jun 28, 2023

Build failed:

@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/Geometry.Euclidean.MongePoint branch from 9c73ca3 to 9cc415d Compare June 28, 2023 18:07
@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 28, 2023
@Ruben-VandeVelde @mo271 @int-y1
feat: port Geometry.Euclidean.MongePoint (#5056)
ec733a5 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@Ruben-VandeVelde
Copy link
Collaborator Author

Conflicted with #5450

@bors
Copy link

bors bot commented Jun 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Euclidean.MongePoint [Merged by Bors] - feat: port Geometry.Euclidean.MongePoint Jun 28, 2023
@bors bors bot closed this Jun 28, 2023
@bors bors bot deleted the port/Geometry.Euclidean.MongePoint branch June 28, 2023 18:36
semorrison pushed a commit that referenced this pull request Jun 29, 2023
@Ruben-VandeVelde @mo271
@int-y1 @semorrison
feat: port Geometry.Euclidean.MongePoint (#5056)
3e86138 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
semorrison pushed a commit that referenced this pull request Jun 29, 2023
@Ruben-VandeVelde @semorrison
parent f90c0b2
769c817 
author Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> 1687976574 +0000
committer Scott Morrison <scott.morrison@gmail.com> 1688001174 +1000

feat: port Geometry.Euclidean.MongePoint (#5056)

Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>

first cut of 'lake exe graph'

feat: lake exe graph

update help text

fixes

nameset

fix test
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@Ruben-VandeVelde @mo271
@int-y1 @kbuzzard
feat: port Geometry.Euclidean.MongePoint (#5056)
a0201d0 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Ruben-VandeVelde @mo271
@int-y1 @semorrison
feat: port Geometry.Euclidean.MongePoint (#5056)
75adf8c 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @int-y1 @jcommelin @semorrison @mo271