Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: use mathport output in FieldTheory.SplittingField.Construction #5087

Closed
wants to merge 7 commits into from

Conversation

riccardobrasca
Copy link
Member

The mathlib3 version was manually backported from the mathlib4 version. We use here the mathport output.


Open in Gitpod

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 15, 2023
bors bot pushed a commit that referenced this pull request Jun 15, 2023
…#5087)

The mathlib3 version was manually backported from the mathlib4 version. We use here the mathport output.
@bors
Copy link

bors bot commented Jun 15, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: use mathport output in FieldTheory.SplittingField.Construction [Merged by Bors] - chore: use mathport output in FieldTheory.SplittingField.Construction Jun 15, 2023
@bors bors bot closed this Jun 15, 2023
@bors bors bot deleted the RB/splitting_field_again branch June 15, 2023 23:01
jcommelin pushed a commit that referenced this pull request Jun 17, 2023
…#5087)

The mathlib3 version was manually backported from the mathlib4 version. We use here the mathport output.
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
…#5087)

The mathlib3 version was manually backported from the mathlib4 version. We use here the mathport output.
semorrison pushed a commit that referenced this pull request Jun 25, 2023
…#5087)

The mathlib3 version was manually backported from the mathlib4 version. We use here the mathport output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants