[Merged by Bors] - feat: port Logic.Function.Basic #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far I've done the merge with the existing file, using previously ported proofs where the mathport proof is broken. But I haven't attempted to
|
1 task
|
The problem with congr has been fixed in Lean 4, but we can't move to nightly-2022-10-29 because of leanprover/lean4#1791. |
Have to explicitly state `invFun` and `extend` via `@dite`, zulip: https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Decidable.20of.20Exists.20changes.20.60if.60.20macro.20semantics proofs for `Eq.mp`, `Eq.mpr`, `Eq.cast` don't see through to `Eq.rec` anymore statements for `LeftInverse.eq_rec_eq` and `eq_rec_on_eq` use explicit `@Eq.rec` for similar reason
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
semorrison
added
awaiting-review
and removed
help-wanted
semorrison
changed the title
|
Depends on #522 |
gebner
added
blocked-by-other-PR
pechersky
added
awaiting-review
and removed
blocked-by-other-PR
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yakov Pechersky <ypechersky@treeline.bio>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.