Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: forward port leanprover-community/mathlib#19178 #5112

Closed
wants to merge 3 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Which really only consists of a SHA update.


Open in Gitpod

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-CI labels Jun 16, 2023
@urkud
Copy link
Member

urkud commented Jun 16, 2023

I can't find it on the porting dashboard.

@Parcly-Taxel
Copy link
Collaborator Author

I can't find it on the porting dashboard.

Wait 30 minutes or so.

@Parcly-Taxel
Copy link
Collaborator Author

@urkud and now it's there.

@riccardobrasca
Copy link
Member

Can we remove the haveI line also in Lean4?

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 19, 2023
@Parcly-Taxel
Copy link
Collaborator Author

Can we remove the haveI line also in Lean4?

Yes.

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 20, 2023
@riccardobrasca
Copy link
Member

Thanks!

bors d+

@bors
Copy link

bors bot commented Jun 20, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 20, 2023
@Parcly-Taxel
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 20, 2023
Which really only consists of a SHA update.
@bors
Copy link

bors bot commented Jun 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward port leanprover-community/mathlib#19178 [Merged by Bors] - chore: forward port leanprover-community/mathlib#19178 Jun 20, 2023
@bors bors bot closed this Jun 20, 2023
@bors bors bot deleted the sha19178 branch June 20, 2023 08:27
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
Which really only consists of a SHA update.
semorrison pushed a commit that referenced this pull request Jun 23, 2023
Which really only consists of a SHA update.
semorrison pushed a commit that referenced this pull request Jun 23, 2023
Which really only consists of a SHA update.
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Which really only consists of a SHA update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants