[Merged by Bors] - chore(Topology/{Paracompact + PartitionOfUnity + Algebra/Order/Compact}): restore a more faithful mathported proof, using the "newer" push_neg
#5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
changed the title
push_negpush_neg
adomani
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 18, 2023
…t}): restore a more faithful mathported proof, using the "newer" `push_neg` (#5132) These are just three cases where a mathported proof had to be changed, due to unwanted behaviour with `push_neg/contradiction`. Since #5082 is supposed to fix some issues with these tactics, some of these workarounds can be removed. Note: this was not in any way systematic, I simply `grep`ped the line after a `contra`, then `grep`ped for a `not` and then selected 3 likely candidates. There are potentially more situations like these.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
push_negpush_neg
semorrison
pushed a commit
that referenced
this pull request
Jun 19, 2023
…t}): restore a more faithful mathported proof, using the "newer" `push_neg` (#5132) These are just three cases where a mathported proof had to be changed, due to unwanted behaviour with `push_neg/contradiction`. Since #5082 is supposed to fix some issues with these tactics, some of these workarounds can be removed. Note: this was not in any way systematic, I simply `grep`ped the line after a `contra`, then `grep`ped for a `not` and then selected 3 likely candidates. There are potentially more situations like these.
alexkeizer
pushed a commit
that referenced
this pull request
Jun 22, 2023
…t}): restore a more faithful mathported proof, using the "newer" `push_neg` (#5132) These are just three cases where a mathported proof had to be changed, due to unwanted behaviour with `push_neg/contradiction`. Since #5082 is supposed to fix some issues with these tactics, some of these workarounds can be removed. Note: this was not in any way systematic, I simply `grep`ped the line after a `contra`, then `grep`ped for a `not` and then selected 3 likely candidates. There are potentially more situations like these.
semorrison
pushed a commit
that referenced
this pull request
Jun 23, 2023
…t}): restore a more faithful mathported proof, using the "newer" `push_neg` (#5132) These are just three cases where a mathported proof had to be changed, due to unwanted behaviour with `push_neg/contradiction`. Since #5082 is supposed to fix some issues with these tactics, some of these workarounds can be removed. Note: this was not in any way systematic, I simply `grep`ped the line after a `contra`, then `grep`ped for a `not` and then selected 3 likely candidates. There are potentially more situations like these.
semorrison
pushed a commit
that referenced
this pull request
Jun 25, 2023
…t}): restore a more faithful mathported proof, using the "newer" `push_neg` (#5132) These are just three cases where a mathported proof had to be changed, due to unwanted behaviour with `push_neg/contradiction`. Since #5082 is supposed to fix some issues with these tactics, some of these workarounds can be removed. Note: this was not in any way systematic, I simply `grep`ped the line after a `contra`, then `grep`ped for a `not` and then selected 3 likely candidates. There are potentially more situations like these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just three cases where a mathported proof had to be changed, due to unwanted behaviour with
push_neg/contradiction. Since #5082 is supposed to fix some issues with these tactics, some of these workarounds can be removed.Note: this was not in any way systematic, I simply
grepped the line after acontra, thengrepped for anotand then selected 3 likely candidates. There are potentially more situations like these.