Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port NumberTheory.Pell #5137

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port NumberTheory.Pell #5137

wants to merge 11 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. WIP Work in progress and removed help-wanted The author needs attention to resolve issues labels Jun 16, 2023
@Ruben-VandeVelde
feat: port NumberTheory.Pell
e48b28d
@Ruben-VandeVelde
Initial file copy from mathport
936c732
@Ruben-VandeVelde
automated fixes
a19f2e5 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
wip
c88dae4
@Ruben-VandeVelde
wip
6648368
@Ruben-VandeVelde
wip
6b0c9dc
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels Jun 16, 2023
jcommelin
jcommelin approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 16, 2023
bors bot pushed a commit that referenced this pull request Jun 16, 2023
@Ruben-VandeVelde
feat: port NumberTheory.Pell (#5137)
2edc8bf
@bors
Copy link

bors bot commented Jun 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port NumberTheory.Pell [Merged by Bors] - feat: port NumberTheory.Pell Jun 16, 2023
@bors bors bot closed this Jun 16, 2023
@bors bors bot deleted the port/NumberTheory.Pell branch June 16, 2023 12:03
jcommelin pushed a commit that referenced this pull request Jun 17, 2023
@Ruben-VandeVelde @jcommelin
feat: port NumberTheory.Pell (#5137)
ca87cd9
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@Ruben-VandeVelde @alexkeizer
feat: port NumberTheory.Pell (#5137)
fbc8e6b
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@Ruben-VandeVelde @semorrison
feat: port NumberTheory.Pell (#5137)
33821bd
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@Ruben-VandeVelde @semorrison
feat: port NumberTheory.Pell (#5137)
f5a34d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @jcommelin @semorrison