Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port FieldTheory.PolynomialGaloisGroup #5159

Closed
wants to merge 22 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented Jun 16, 2023


TODO:

  • timeouts
  • failed to synthesize instance IsScalarTower ℚ ℝ ℂ

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Jun 16, 2023
@Ruben-VandeVelde Ruben-VandeVelde removed the help-wanted The author needs attention to resolve issues label Jun 17, 2023
@Ruben-VandeVelde Ruben-VandeVelde added the help-wanted The author needs attention to resolve issues label Jun 17, 2023
@xroblot
Copy link
Collaborator

xroblot commented Jun 21, 2023

I am going to work in this PR for a while

@xroblot
Copy link
Collaborator

xroblot commented Jun 21, 2023

I was able to fix a timeout (well, still needs 300000 heartbeats) but was unsuccessful with the IsScalarTower issue. I made a Zulip thread to get some help.

@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR to Mathlib label Jun 21, 2023
@xroblot xroblot removed the help-wanted The author needs attention to resolve issues label Jun 21, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Jun 22, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 23, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR awaiting-CI labels Jun 23, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 23, 2023
bors bot pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port FieldTheory.PolynomialGaloisGroup [Merged by Bors] - feat: port FieldTheory.PolynomialGaloisGroup Jun 23, 2023
@bors bors bot closed this Jun 23, 2023
@bors bors bot deleted the port/FieldTheory.PolynomialGaloisGroup branch June 23, 2023 12:17
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
semorrison pushed a commit that referenced this pull request Jun 28, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants