Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: resolve a porting note in Profinite/CofilteredLimit #5168

Closed
wants to merge 2 commits into from

Conversation

semorrison
Copy link
Contributor

To create new goals from have you need to use ?_, rather than _.


Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 17, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 17, 2023
@dagurtomas
Copy link
Collaborator

To create new goals from have you need to use ?_, rather than _.

Thanks, I didn't know that!

Copy link
Collaborator

@dagurtomas dagurtomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors bot pushed a commit that referenced this pull request Jun 17, 2023
To create new goals from `have` you need to use `?_`, rather than `_`.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: resolve a porting note in Profinite/CofilteredLimit [Merged by Bors] - chore: resolve a porting note in Profinite/CofilteredLimit Jun 17, 2023
@bors bors bot closed this Jun 17, 2023
@bors bors bot deleted the cofiltered_limit_porting_note branch June 17, 2023 09:08
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
To create new goals from `have` you need to use `?_`, rather than `_`.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
semorrison added a commit that referenced this pull request Jun 23, 2023
To create new goals from `have` you need to use `?_`, rather than `_`.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
semorrison added a commit that referenced this pull request Jun 25, 2023
To create new goals from `have` you need to use `?_`, rather than `_`.



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants