Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: cleanup of some ext porting notes #5176

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: cleanup of some ext porting notes #5176

wants to merge 1 commit into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Jun 17, 2023
jcommelin
jcommelin approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jun 17, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 17, 2023
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jun 17, 2023
bors bot pushed a commit that referenced this pull request Jun 17, 2023
@semorrison
chore: cleanup of some ext porting notes (#5176)
6ffd1a5 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: cleanup of some ext porting notes [Merged by Bors] - chore: cleanup of some ext porting notes Jun 17, 2023
@bors bors bot closed this Jun 17, 2023
@bors bors bot deleted the ext_cleanup branch June 17, 2023 09:08
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@semorrison @alexkeizer
chore: cleanup of some ext porting notes (#5176)
5e17aad 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
semorrison added a commit that referenced this pull request Jun 23, 2023
@semorrison
chore: cleanup of some ext porting notes (#5176)
3fcad1e 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
semorrison added a commit that referenced this pull request Jun 25, 2023
@semorrison
chore: cleanup of some ext porting notes (#5176)
a9c1b2b 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @jcommelin