Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.IsAdjoinRoot #5190

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.IsAdjoinRoot #5190

wants to merge 9 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented Jun 17, 2023

Open in Gitpod

@xroblot
feat: port RingTheory.IsAdjoinRoot
5629312
@xroblot
Initial file copy from mathport
4e63564
@xroblot
automated fixes
08dbd56 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@xroblot xroblot added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 17, 2023
@xroblot xroblot added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels Jun 18, 2023
jcommelin
jcommelin approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 19, 2023
bors bot pushed a commit that referenced this pull request Jun 19, 2023
@xroblot
feat: port RingTheory.IsAdjoinRoot (#5190)
a3b008b
@bors
Copy link

bors bot commented Jun 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.IsAdjoinRoot [Merged by Bors] - feat: port RingTheory.IsAdjoinRoot Jun 19, 2023
@bors bors bot closed this Jun 19, 2023
@bors bors bot deleted the port/RingTheory.IsAdjoinRoot branch June 19, 2023 04:31
semorrison pushed a commit that referenced this pull request Jun 19, 2023
@xroblot
feat: port RingTheory.IsAdjoinRoot (#5190)
233bd7f
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@xroblot @alexkeizer
feat: port RingTheory.IsAdjoinRoot (#5190)
f81afa5
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@xroblot @semorrison
feat: port RingTheory.IsAdjoinRoot (#5190)
ec7c1dd
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@xroblot @semorrison
feat: port RingTheory.IsAdjoinRoot (#5190)
b773cee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @jcommelin @semorrison