Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: define MeasureTheory.Lp.const #5236

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: define MeasureTheory.Lp.const #5236

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 18, 2023 •
edited by sgouezel

Lean fails to generate the Norm instance in 1 lemma. I tried to use letI and failed.

Open in Gitpod

@urkud urkud added help-wanted The author needs attention to resolve issues awaiting-review The author would like community review of the PR new-feature Add features not present in Mathlib 3 CI Modifies the continuous integration / deployment setup awaiting-CI and removed CI Modifies the continuous integration / deployment setup labels Jun 18, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 18, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 19, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@sgouezel
Copy link
Contributor

Can you merge master?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 29, 2023
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 30, 2023
@sgouezel
Copy link
Contributor

Is the help-wanted tag still accurate?

@urkud
Copy link
Member Author

urkud commented Jun 30, 2023

Yes, Lean fails to generate Norm instance in the commented lemma.

@urkud
Copy link
Member Author

urkud commented Jul 27, 2023

@sgouezel It turns out that the issue was with NormedField vs NontriviallyNormedField, not with Lean instance search.

@urkud urkud removed the help-wanted The author needs attention to resolve issues label Jul 27, 2023
@RemyDegenne RemyDegenne added the t-measure-probability Measure theory / Probability theory label Jul 27, 2023
RemyDegenne
RemyDegenne reviewed Jul 27, 2023
View reviewed changes
Mathlib/MeasureTheory/Function/LpSpace.lean Outdated
rw [← Memℒp.toLp_const, indicatorConstLp]
simp only [Set.indicator_univ, Function.const]

theorem Lp.norm_const (hp_zero : p ≠ 0) (hmeas : μ ≠ 0) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the NeZero PR was merged? If yes, would that be better?

Suggested change
theorem Lp.norm_const (hp_zero : p ≠ 0) (hmeas : μ ≠ 0) :
theorem Lp.norm_const (hp_zero : p ≠ 0) [NeZero μ] :

@RemyDegenne
Copy link
Contributor

LGTM!
bors d+

@bors
Copy link

bors bot commented Jul 27, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot removed the awaiting-review The author would like community review of the PR label Jul 27, 2023
@urkud
Copy link
Member Author

urkud commented Jul 27, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 27, 2023
bors bot pushed a commit that referenced this pull request Jul 27, 2023
@urkud
feat: define MeasureTheory.Lp.const (#5236)
b9dadb4
@bors
Copy link

bors bot commented Jul 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: define MeasureTheory.Lp.const [Merged by Bors] - feat: define MeasureTheory.Lp.const Jul 27, 2023
@bors bors bot closed this Jul 27, 2023
@bors bors bot deleted the YK-Lp-const branch July 27, 2023 14:26
adomani pushed a commit that referenced this pull request Jul 28, 2023
@urkud @adomani
feat: define MeasureTheory.Lp.const (#5236)
4c2bf36
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@urkud @semorrison
feat: define MeasureTheory.Lp.const (#5236)
c5245f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyDegenne RemyDegenne RemyDegenne left review comments

Assignees
No one assigned
Labels
delegated new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
Ergodicity of the irrational rotation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @semorrison @sgouezel @RemyDegenne