[Merged by Bors] - chore(NumberTheory/WellApproximable): golf proof using tauto
#5263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `tauto` here was annoyingly slow in Lean 3 but is not in Lean 4. On the other hand, the Lean 4 proof is much slower overall than Lean 3. Using `set_option profiler true` this seems to be a problem with coercions since I see 20 typeclass searches as follows: ``` typeclass inference of CoeT took 384ms typeclass inference of CoeT took 368ms typeclass inference of CoeT took 328ms typeclass inference of CoeT took 306ms typeclass inference of CoeT took 307ms typeclass inference of CoeT took 309ms typeclass inference of CoeT took 307ms typeclass inference of CoeT took 308ms typeclass inference of CoeT took 335ms typeclass inference of CoeT took 307ms typeclass inference of CoeT took 307ms typeclass inference of CoeT took 309ms typeclass inference of CoeT took 307ms typeclass inference of CoeT took 308ms typeclass inference of CoeT took 306ms typeclass inference of CoeT took 306ms typeclass inference of CoeT took 312ms typeclass inference of CoeT took 324ms typeclass inference of CoeT took 319ms typeclass inference of CoeT took 312ms ``` (adding up to nearly 6.5 seconds).
ocfnash
added
awaiting-review
easy
This removes ~5 seconds of slow instance searches for `CoeT`.
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 21, 2023
Two independent changes are being proposed here: 1. Using `tauto`: this was annoyingly slow in Lean 3 but is not in Lean 4, 2. Changing `p` to `((p : ℕ) : ℝ)`: this is because Lean 4 is unfortunately much worse at coercing from `Nat.Primes` to `Real` and will waste about 5 seconds working on this via `typeclass inference of CoeT` searches without this change. Some discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Slow.20coercions) on Zulip.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
tautotauto
alexkeizer
pushed a commit
that referenced
this pull request
Jun 22, 2023
Two independent changes are being proposed here: 1. Using `tauto`: this was annoyingly slow in Lean 3 but is not in Lean 4, 2. Changing `p` to `((p : ℕ) : ℝ)`: this is because Lean 4 is unfortunately much worse at coercing from `Nat.Primes` to `Real` and will waste about 5 seconds working on this via `typeclass inference of CoeT` searches without this change. Some discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Slow.20coercions) on Zulip.
semorrison
pushed a commit
that referenced
this pull request
Jun 23, 2023
Two independent changes are being proposed here: 1. Using `tauto`: this was annoyingly slow in Lean 3 but is not in Lean 4, 2. Changing `p` to `((p : ℕ) : ℝ)`: this is because Lean 4 is unfortunately much worse at coercing from `Nat.Primes` to `Real` and will waste about 5 seconds working on this via `typeclass inference of CoeT` searches without this change. Some discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Slow.20coercions) on Zulip.
semorrison
pushed a commit
that referenced
this pull request
Jun 23, 2023
Two independent changes are being proposed here: 1. Using `tauto`: this was annoyingly slow in Lean 3 but is not in Lean 4, 2. Changing `p` to `((p : ℕ) : ℝ)`: this is because Lean 4 is unfortunately much worse at coercing from `Nat.Primes` to `Real` and will waste about 5 seconds working on this via `typeclass inference of CoeT` searches without this change. Some discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Slow.20coercions) on Zulip.
semorrison
pushed a commit
that referenced
this pull request
Jun 25, 2023
Two independent changes are being proposed here: 1. Using `tauto`: this was annoyingly slow in Lean 3 but is not in Lean 4, 2. Changing `p` to `((p : ℕ) : ℝ)`: this is because Lean 4 is unfortunately much worse at coercing from `Nat.Primes` to `Real` and will waste about 5 seconds working on this via `typeclass inference of CoeT` searches without this change. Some discussion [here](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Slow.20coercions) on Zulip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two independent changes are being proposed here:
tauto: this was annoyingly slow in Lean 3 but is not in Lean 4,pto((p : ℕ) : ℝ): this is because Lean 4 is unfortunately much worse at coercing fromNat.PrimestoRealand will waste about 5 seconds working on this viatypeclass inference of CoeTsearches without this change.Some discussion here on Zulip.