Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add Metric.Bounded.vadd #5270

Closed
wants to merge 2 commits into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 19, 2023

Add Metric.Bounded.smul and Metric.Bounded.vadd, rename the old smul to smul₀.


Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR awaiting-CI new-feature Add features not present in Mathlib 3 labels Jun 19, 2023
@ADedecker
Copy link
Member

Could you add a comment on Metric.Bounded.smul along the lines of "This result is about isometric actions, see Metric.Bounded.smul₀ for the result for NormedSpaces". I could very well imagine searching for the NormedSpace lemma and searching for this exact name.

@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 30, 2023
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 30, 2023
@urkud
Copy link
Member Author

urkud commented Jun 30, 2023

Could you add a comment on Metric.Bounded.smul along the lines of "This result is about isometric actions, see Metric.Bounded.smul₀ for the result for NormedSpaces". I could very well imagine searching for the NormedSpace lemma and searching for this exact name.

I added some comments. Feel free to edit them.

@ADedecker
Copy link
Member

ADedecker commented Jun 30, 2023

The docstrings are perfect, thanks.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by ADedecker.

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 30, 2023
bors bot pushed a commit that referenced this pull request Jun 30, 2023
Add `Metric.Bounded.smul` and `Metric.Bounded.vadd`, rename the old `smul` to `smul₀`.
@bors
Copy link

bors bot commented Jun 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add Metric.Bounded.vadd [Merged by Bors] - feat: add Metric.Bounded.vadd Jun 30, 2023
@bors bors bot closed this Jun 30, 2023
@bors bors bot deleted the YK-bdd-smul branch June 30, 2023 17:15
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Add `Metric.Bounded.smul` and `Metric.Bounded.vadd`, rename the old `smul` to `smul₀`.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Add `Metric.Bounded.smul` and `Metric.Bounded.vadd`, rename the old `smul` to `smul₀`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants