Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Counterexamples.HomogeneousPrimeNotPrime #5287

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Counterexamples.HomogeneousPrimeNotPrime #5287

wants to merge 11 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Jun 20, 2023

Open in Gitpod

@mo271
feat: port Counterexamples.HomogeneousPrimeNotPrime
94f28b6
@mo271
Initial file copy from mathport
a38ec21
@mo271
automated fixes
b35e19d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Counterexamples.lean
@mo271
starting
cb18ec1
@mo271 mo271 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Jun 20, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Jun 20, 2023

Some dec_trivial are not working, and also the LinearOrderedAddCommMonoid Two needs fixing
7 errors currently

@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels Jul 3, 2023
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 3, 2023
@jcommelin jcommelin added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 5, 2023
@bors
Copy link

bors bot commented Jul 5, 2023

✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 5, 2023
bors bot pushed a commit that referenced this pull request Jul 5, 2023
@mo271 @jcommelin
feat: port Counterexamples.HomogeneousPrimeNotPrime (#5287)
8c0a68a 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jul 5, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Counterexamples.HomogeneousPrimeNotPrime [Merged by Bors] - feat: port Counterexamples.HomogeneousPrimeNotPrime Jul 5, 2023
@bors bors bot closed this Jul 5, 2023
@bors bors bot deleted the port/Counterexamples.HomogeneousPrimeNotPrime branch July 5, 2023 18:37
semorrison pushed a commit that referenced this pull request Jul 6, 2023
@mo271 @jcommelin @semorrison
feat: port Counterexamples.HomogeneousPrimeNotPrime (#5287)
6449f5b 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@mo271 @jcommelin @kbuzzard
feat: port Counterexamples.HomogeneousPrimeNotPrime (#5287)
9fede5c 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@mo271 @jcommelin @semorrison
feat: port Counterexamples.HomogeneousPrimeNotPrime (#5287)
9176a7d 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @jcommelin @urkud