Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add nhds_basis_Icc_pos #5295

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: add nhds_basis_Icc_pos #5295

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 20, 2023

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR new-feature Add features not present in Mathlib 3 easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 20, 2023
dupuisf
dupuisf reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
bors bot pushed a commit that referenced this pull request Jun 21, 2023
@urkud
feat: add nhds_basis_Icc_pos (#5295)
357016d
@bors
Copy link

bors bot commented Jun 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add nhds_basis_Icc_pos [Merged by Bors] - feat: add nhds_basis_Icc_pos Jun 21, 2023
@bors bors bot closed this Jun 21, 2023
@bors bors bot deleted the YK-nhds-basis-Icc branch June 21, 2023 03:32
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@urkud @alexkeizer
feat: add nhds_basis_Icc_pos (#5295)
688827f
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@urkud @semorrison
feat: add nhds_basis_Icc_pos (#5295)
aac042a
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@urkud @semorrison
feat: add nhds_basis_Icc_pos (#5295)
52435a0
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@urkud @semorrison
feat: add nhds_basis_Icc_pos (#5295)
9e9bc9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors.
Projects
Homeomorphism between convex sets
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @dupuisf @semorrison