[Merged by Bors] - feat: port RingTheory.Ideal.Norm #5311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Ruben-VandeVelde
commented
Jun 20, 2023
Ruben-VandeVelde
commented
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Ruben-VandeVelde
added
WIP
Ruben-VandeVelde
added
help-wanted
|
I am working on this file for a bit |
|
I am almost done with this one but I have to go to sleep. I’ll push my changes tomorrow. |
xroblot
added
WIP
xroblot
added
awaiting-review
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
semorrison
pushed a commit
that referenced
this pull request
Jun 23, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
semorrison
pushed a commit
that referenced
this pull request
Jun 23, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
semorrison
pushed a commit
that referenced
this pull request
Jun 25, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.