[Merged by Bors] - fix: don't change bornology with PseudoMetricSpace.replaceUniformity
#5330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
awaiting-review
4 tasks
|
Should that example by added to guard against a future change breaking the definitional equality? Happy if that doesn't seem necessary to you. bors d+ |
|
✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
#5330) This fixes `PseudoMetricSpace.replaceUniformity` so that it no longer silently changes the bornology. Before the fix, the following example fails, but afterwards, it succeeds. ```lean example {α} [U : UniformSpace α] (m : PseudoMetricSpace α) (H : 𝓤[U] = 𝓤[PseudoEMetricSpace.toUniformSpace]) : (PseudoMetricSpace.replaceUniformity m H).toBornology = m.toBornology := rfl ```
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
PseudoMetricSpace.replaceUniformityPseudoMetricSpace.replaceUniformity
semorrison
pushed a commit
that referenced
this pull request
Jun 25, 2023
#5330) This fixes `PseudoMetricSpace.replaceUniformity` so that it no longer silently changes the bornology. Before the fix, the following example fails, but afterwards, it succeeds. ```lean example {α} [U : UniformSpace α] (m : PseudoMetricSpace α) (H : 𝓤[U] = 𝓤[PseudoEMetricSpace.toUniformSpace]) : (PseudoMetricSpace.replaceUniformity m H).toBornology = m.toBornology := rfl ```
semorrison
pushed a commit
that referenced
this pull request
Jun 28, 2023
#5330) This fixes `PseudoMetricSpace.replaceUniformity` so that it no longer silently changes the bornology. Before the fix, the following example fails, but afterwards, it succeeds. ```lean example {α} [U : UniformSpace α] (m : PseudoMetricSpace α) (H : 𝓤[U] = 𝓤[PseudoEMetricSpace.toUniformSpace]) : (PseudoMetricSpace.replaceUniformity m H).toBornology = m.toBornology := rfl ```
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
#5330) This fixes `PseudoMetricSpace.replaceUniformity` so that it no longer silently changes the bornology. Before the fix, the following example fails, but afterwards, it succeeds. ```lean example {α} [U : UniformSpace α] (m : PseudoMetricSpace α) (H : 𝓤[U] = 𝓤[PseudoEMetricSpace.toUniformSpace]) : (PseudoMetricSpace.replaceUniformity m H).toBornology = m.toBornology := rfl ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
PseudoMetricSpace.replaceUniformityso that it no longer silently changes the bornology. Before the fix, the following example fails, but afterwards, it succeeds.example {α} [U : UniformSpace α] (m : PseudoMetricSpace α) (H : 𝓤[U] = 𝓤[PseudoEMetricSpace.toUniformSpace]) : (PseudoMetricSpace.replaceUniformity m H).toBornology = m.toBornology := rfl