Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port NumberTheory.Cyclotomic.Basic #5335

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat: port NumberTheory.Cyclotomic.Basic #5335

wants to merge 18 commits into from

Conversation

riccardobrasca
Copy link
Member

Open in Gitpod

@riccardobrasca
feat: port NumberTheory.Cyclotomic.Basic
d5a6a57
@riccardobrasca
Initial file copy from mathport
444aeca
@riccardobrasca
automated fixes
501b137 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@riccardobrasca riccardobrasca added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 21, 2023
@Ruben-VandeVelde Ruben-VandeVelde changed the title Port/NumberTheory.Cyclotomic.Basic feat: port NumberTheory.Cyclotomic.Basic Jun 21, 2023
@riccardobrasca riccardobrasca added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 21, 2023
@riccardobrasca riccardobrasca added WIP Work in progress and removed help-wanted The author needs attention to resolve issues labels Jun 21, 2023
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed mathlib-port This is a port of a theory file from mathlib. labels Jun 21, 2023
@Parcly-Taxel Parcly-Taxel added mathlib-port This is a port of a theory file from mathlib. and removed WIP Work in progress labels Jun 22, 2023
urkud
urkud approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Thanks!

Mathlib/NumberTheory/Cyclotomic/Basic.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/Basic.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/Basic.lean Show resolved Hide resolved
Mathlib/NumberTheory/Cyclotomic/Basic.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 22, 2023
bors bot pushed a commit that referenced this pull request Jun 22, 2023
@riccardobrasca @ChrisHughes24
feat: port NumberTheory.Cyclotomic.Basic (#5335)
5a55608 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented Jun 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port NumberTheory.Cyclotomic.Basic [Merged by Bors] - feat: port NumberTheory.Cyclotomic.Basic Jun 22, 2023
@bors bors bot closed this Jun 22, 2023
@bors bors bot deleted the port/NumberTheory.Cyclotomic.Basic branch June 22, 2023 09:57
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@riccardobrasca @ChrisHughes24 @alexkeizer
feat: port NumberTheory.Cyclotomic.Basic (#5335)
b07eb8b 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@riccardobrasca @ChrisHughes24 @semorrison
feat: port NumberTheory.Cyclotomic.Basic (#5335)
38436cf 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@riccardobrasca @ChrisHughes24 @semorrison
feat: port NumberTheory.Cyclotomic.Basic (#5335)
2787a69 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@riccardobrasca @ChrisHughes24 @semorrison
feat: port NumberTheory.Cyclotomic.Basic (#5335)
fb80feb 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@riccardobrasca @ChrisHughes24 @kbuzzard
feat: port NumberTheory.Cyclotomic.Basic (#5335)
9aee20e 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@riccardobrasca @urkud @jcommelin @semorrison @Parcly-Taxel @ChrisHughes24