[Merged by Bors] - feat: port NumberTheory.ClassNumber.Finite #5337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Genora51
commented
Jun 21, 2023
Genora51
commented
Genora51
changed the title
Genora51
added
WIP
semorrison
added
the
merge-conflict
|
Currently struggling with a couple of errors that I can't seem to resolve, plus a timeout issue on |
|
Can you please fix the conflict? Not sure I have time today, but I will have a look tomorrow. |
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Genora51
force-pushed
the
port/NumberTheory.ClassNumber.Finite
branch
from
553d393
to
582df94
Compare
|
@riccardobrasca I've rebased onto latest |
semorrison
removed
the
merge-conflict
|
|
||
| attribute [-instance] Real.decidableEq | ||
|
|
||
| set_option maxHeartbeats 800000 in |
There was a problem hiding this comment.
This proof is rather slow. Maybe @Vierkantor wants to have a look at it (but it is already slow in mathlib3).
|
@Genora51 I think this is now green. I didn't fix any doc/name. |
Genora51
added
awaiting-review
| finite extension `L` of `K = Frac(R)` is finite if there is an admissible | ||
| absolute value. | ||
|
|
||
| See also `class_group.fintype_of_admissible_of_algebraic` where `L` is an |
There was a problem hiding this comment.
This name is still the mathlib3 name.
jcommelin
reviewed
Jun 24, 2023
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
semorrison
pushed a commit
that referenced
this pull request
Jun 25, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
semorrison
pushed a commit
that referenced
this pull request
Jun 28, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
kbuzzard
pushed a commit
that referenced
this pull request
Jul 6, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
Co-authored-by: Chris Hughes <chrishughes24@gmail.com> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.